Skip to content

fix(@schematics/angular): alphabetically order imports during component generation #23159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eltonc-dev
Copy link
Contributor

change the order of imports during component generation using changeDetectionStrategy set to OnPush

closes #23156

alan-agius4
alan-agius4 previously approved these changes May 18, 2022
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please change the commit scope to @schematics/angular?

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels May 18, 2022
…nt generation

change the order of imports during component generation using changeDetectionStrategy set to OnPush

closes angular#23156
@eltonc-dev eltonc-dev force-pushed the fix/alphabetically-import-using-on-push branch from b6b838e to 7ba1c76 Compare May 18, 2022 12:58
@eltonc-dev
Copy link
Contributor Author

LGTM, can you please change the commit scope to @schematics/angular?

Ty! I made the change.

@alan-agius4 alan-agius4 changed the title fix(@angular/cli): alphabetically order imports during component generation fix(@schematics/angular): alphabetically order imports during component generation May 18, 2022
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 18, 2022
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clydin clydin added this to the v14 milestone May 18, 2022
@clydin clydin added target: rc This PR is targeted for the next release-candidate target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release target: rc This PR is targeted for the next release-candidate labels May 18, 2022
@clydin clydin merged commit d899091 into angular:main May 18, 2022
@clydin
Copy link
Member

clydin commented May 18, 2022

Merge conflicts detected against the patch branch (13.3.x). Switching to target RC. If you'd like this change to be available on the patch branch (13.3.x), please open a separate PR targeting 13.3.x.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
3 participants