fix(@angular/cli): resolve relative schematic from angular.json instead of current working directory
#23138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of current working directory Relative schematics referenced in `angular.json` `schematicCollections` and `defaultCollection` were always resolved from the current working directory, which is not correct and caused the collection not to be resolved when the this is different from the location of the workspace config. Closes angular#23136
alan-agius4
added
action: review
alan-agius4
force-pushed
the
cwd-schematic-resolution
branch
from
745a76e to
1155e50
Compare
clydin
approved these changes
May 17, 2022
alan-agius4
added
action: merge
|
@alan-agius4 Tell me, please, will the fix be published in version 13.x.x? |
I have opened a PR that contains a patch version for this #23167 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative schematics referenced in
angular.jsonschematicCollectionsanddefaultCollectionwere always resolved from the current working directory, which is not correct and caused the collection not to be resolved when the this is different from the location of the workspace config.Closes #23136