-
Notifications
You must be signed in to change notification settings - Fork 12k
test: remove use of global npm cache and config #23115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
979097e
to
3d4d936
Compare
b6774a5
to
4a0ce6f
Compare
2116362
to
02f7039
Compare
Note this started failing after the recent npm changes. I'll try getting it passing again but let me know if there's any feedback on what's here so far... |
b9effb5
to
4dadb25
Compare
07ebfc2
to
faa19bb
Compare
25bd8da
to
f41341f
Compare
Ok I've updated this PR to significantly less changes then previously...
This no longer removes This does NOT prevent the use of the shared global npm database ( |
8d70785
to
289ab02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Removing the use of globally installed npm and npm packages. Instead npm+yarn within the test-runner use npm+yarn from package.json (not globals). Tests no longer depend on any
--global
and use npm+ng installed locally within the temporary test directories.This might be the last step before being able to run multiple tests concurrently (#23114 was the other big one).
This might be the last one before getting the e2e tests working in bazel (#23074)
EDIT: this has changed to keep globals but use a isolated global cache per invocation, see comment below
Original attempt removing use of
--global
: 02f7039