Skip to content

fix: using local npm 2 from ember-cli dependency while ng init #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ValeryVS
Copy link
Contributor

fix #2179
look for my/path/to/project/node_modules/.bin and exclude it from path for npm install command

@ValeryVS
Copy link
Contributor Author

The best solution, of course - do not use npm 2 as local dependency. But, pobably, it is not smple task yet.
Also we can beware developers of using node_modules/.bin in path.
Modifying path probably looks hacky, but it works.

@ValeryVS
Copy link
Contributor Author

Actually, we shouldn't use RegExp like this.
Just exclude

  • npm bin output
  • node_modules/.bin
  • node_modules.bin

should be enough.

And, we can check npm -v before install.

I fix PR tomorrow.

@ValeryVS ValeryVS force-pushed the fix/npm-install-env-path branch 3 times, most recently from 8becd56 to c979ecb Compare September 26, 2016 09:36
@ValeryVS
Copy link
Contributor Author

It is done.

  • runs npm bin
  • exclude from path:
  • - npm bin's output
  • - node_modules/.bin
  • - node_modules\.bin
  • runs npm install

@ValeryVS ValeryVS force-pushed the fix/npm-install-env-path branch from 2b83bc2 to 74b3786 Compare September 28, 2016 08:19
@ValeryVS ValeryVS force-pushed the fix/npm-install-env-path branch from 74b3786 to 986f2a5 Compare September 28, 2016 08:47
@ValeryVS
Copy link
Contributor Author

Rebased to master

@filipesilva
Copy link
Contributor

Closed, reasoning in #2179 (comment).

@filipesilva filipesilva closed this Oct 3, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Init error (npm 2 dependency)
3 participants