-
Notifications
You must be signed in to change notification settings - Fork 12k
feat: swap out raw-loader for html-loader for html files #2298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: swap out raw-loader for html-loader for html files #2298
Conversation
LGTM. I'll wait for tests to pass. |
Looks like tests failed on basehref, I'll give this another whirl |
Almost there, would be great to have this fixed in the coming update! |
TBH if you wanna replace our custom base href plugin by base functionality of HTMLPlugin, I can't say I mind. Might be the sort of stuff that would happen in a different commit/pr. |
Will this PR be merged soon? :) |
@TheLarkInn Have you tried running |
@hansl I noticed that in your PR you had html-loader (the AOT one), so I hadn't revisited it. |
I'll take a look at this next and see what errors are being caused. |
Closed since we removed this in #2537 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
* angular html components as well as index.html now have the benefits of html-loader