Skip to content

fix(@angular-devkit/build-angular): don't rename blocks which have a name #22740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2022
Merged

fix(@angular-devkit/build-angular): don't rename blocks which have a name #22740

merged 1 commit into from
Feb 22, 2022

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Feb 20, 2022

When using the unsupported webpackChunkName magic comment we renamed the chunk which in some cases causes a runtime error.

Closes #22525

@alan-agius4 alan-agius4 marked this pull request as ready for review February 21, 2022 10:30
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Feb 21, 2022
@alan-agius4 alan-agius4 requested a review from clydin February 21, 2022 10:30
…name

When using the unsupported `webpackChunkName` magic comment we renamed the chunk which in some cases causes a runtime error.

Closes #22525
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Feb 22, 2022
@clydin clydin merged commit de14293 into angular:master Feb 22, 2022
@alan-agius4 alan-agius4 deleted the webpack-named-plugin branch February 22, 2022 21:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to serve or build app due to runtime ChunkLoadError
2 participants