fix(@ngtools/webpack): support locating PNPM lock file during NGCC processing #22633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
…ocessing Previously, we only handled Yarn and NPM lock files even though PNPM is supported as package manager. The lock file is used to perform checks to determine if an initial execution of NGCC was already performed. Closes #22632
dgp1130
approved these changes
Feb 2, 2022
| } catch {} | ||
| } | ||
|
|
||
| throw new Error('Cannot locate a package manager lock file.'); |
There was a problem hiding this comment.
Should we list the files we tried in this error message? Otherwise it's hard to know if the CLI is looking in the wrong place or if the file itself was misplaced.
There was a problem hiding this comment.
Actually this error message is never shown to the users. As this is non fatal and the exception is caught at a later stage.
There was a problem hiding this comment.
Up to you, could be useful for local development if it's ever thrown for an unexpected reason.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only handled Yarn and NPM lock files even though PNPM is supported as package manager.
The lock file is used to perform checks to determine if an initial execution of NGCC was already performed.
Closes #22632