-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@angular-devkit/build-angular): ensure to use content hash as filenames hashing mechanism #22612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly was non-deterministic that is fixed? I don't see anything too obvious being changed, is it updating .[hash:${length}]
-> .[contenthash:${length}]
?
Yes |
I think this conflicted with another PR, I'd fix it in GitHub, but I think that will create a merge commit. Probably easier for you to fix when you get a chance @alan-agius4. |
…enames hashing mechanism Previously we used hash which resulted in a unique hash generated for every build even when the contents of the files didn't differ. More info: https://webpack.js.org/guides/caching/#output-filenames
Merged to patch in #22623, so retargeting this PR to |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Previously we used hash which resulted in a unique hash generated for every build even when the contents of the files didn't differ.
More info: https://webpack.js.org/guides/caching/#output-filenames
NB: I did try to add a unit test, but it non trivial.