Skip to content

feat(@schematics/angular): update Angular dependencies to use ^ as version prefix #22571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2022
Merged

feat(@schematics/angular): update Angular dependencies to use ^ as version prefix #22571

merged 2 commits into from
Jan 27, 2022

Conversation

alan-agius4
Copy link
Collaborator

With this change we update Angular dependencies to use ^ instead of ~ as version prefix.

Closes #21925

@alan-agius4
refactor(@schematics/angular): remove version 13 migrations
aaeeaf2 
These migrations cannot be used with version Angular CLI 14, since `ng update` will not allow updating multiple versions at once.
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Jan 25, 2022
@alan-agius4 alan-agius4 requested a review from dgp1130 January 25, 2022 14:39
@alan-agius4 alan-agius4 marked this pull request as ready for review January 25, 2022 14:39
dgp1130
dgp1130 approved these changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I assume the typical ng update version bumps already respect the user's prefix and won't clobber the ^ with a ~? Just want to make sure it doesn't overwrite all this hard work.

@dgp1130
Copy link
Collaborator

dgp1130 commented Jan 25, 2022

Also, let's hold off on merging breaking changes like this until we're sure that we aren't doing 13.3.

@alan-agius4
feat(@schematics/angular): update Angular dependencies to use ^ as …
ba209a0 
…version prefix

With this change we update Angular dependencies to use `^` instead of `~` as version prefix.

Closes #21925
@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Jan 26, 2022 •
edited
Loading

I assume the typical ng update version bumps already respect the user's prefix and won't clobber the ^ with a ~? Just want to make sure it doesn't overwrite all this hard work.

Yeah, that's right.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jan 26, 2022
@dgp1130 dgp1130 merged commit 7e7de68 into angular:master Jan 27, 2022
@alan-agius4 alan-agius4 deleted the migration-v14 branch January 27, 2022 19:10
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dgp1130 dgp1130 dgp1130 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Angular dependencies to use ^ for semver
2 participants
@alan-agius4 @dgp1130