-
Notifications
You must be signed in to change notification settings - Fork 12k
chore(npm): updated webpack version and config cleanup #2237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
7b7d31b
6ead8bd
8e63c8d
ab8faa8
6a88447
fe07e37
a1771ae
fb8ef37
c08aca7
13c3c0f
eb8017e
c491bf0
0e74c50
f44c869
22e2c27
f6963a1
24d9a16
5877fb5
701a57c
b5326b9
63801b4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -109,7 +109,7 @@ | |
"typedoc": "^0.4.2", | ||
"typescript": "2.0.2", | ||
"url-loader": "^0.5.7", | ||
"webpack": "2.1.0-beta.22", | ||
"webpack": "^2.1.0-beta.23", | ||
"webpack-dev-server": "2.1.0-beta.3", | ||
"webpack-md5-hash": "0.0.5", | ||
"webpack-merge": "^0.14.0", | ||
|
@@ -157,6 +157,7 @@ | |
"tree-kill": "^1.0.0", | ||
"ts-node": "^1.3.0", | ||
"tslint": "^3.11.0", | ||
"walk-sync": "^0.2.6" | ||
"walk-sync": "^0.2.6", | ||
"webpack": "^2.1.0-beta.23" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why dependency and devDependency There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The angular-cli creates a new project, and the repo itself is a dev-dep of the generated project. So in the scope of the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,8 +36,7 @@ export function getWebpackCommonConfig( | |
return { | ||
devtool: 'source-map', | ||
resolve: { | ||
extensions: ['', '.ts', '.js'], | ||
root: appRoot | ||
extensions: ['.ts', '.js'] | ||
}, | ||
context: path.resolve(__dirname, './'), | ||
entry: entry, | ||
|
@@ -46,16 +45,15 @@ export function getWebpackCommonConfig( | |
filename: '[name].bundle.js' | ||
}, | ||
module: { | ||
preLoaders: [ | ||
loaders: [ | ||
{ | ||
enforce: "left", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. preLoader -> enforce: "right" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks I updated this |
||
test: /\.js$/, | ||
loader: 'source-map-loader', | ||
exclude: [ | ||
/node_modules/ | ||
] | ||
} | ||
], | ||
loaders: [ | ||
}, | ||
{ | ||
test: /\.ts$/, | ||
loaders: [ | ||
|
@@ -159,7 +157,7 @@ export function getWebpackCommonConfig( | |
], | ||
node: { | ||
fs: 'empty', | ||
global: 'window', | ||
global: true, | ||
crypto: 'empty', | ||
module: false, | ||
clearImmediate: false, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better fix the version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was working on that as we speak lol!