Skip to content

fix(@angular-devkit/build-angular): fail build when importing CSS files as an ECMA modules #22363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 13, 2021

BREAKING CHANGE:

We now issue a build time error since importing a CSS file as an ECMA module is non standard Webpack specific feature, which is not supported by the Angular CLI.

This feature was never truly supported by the Angular CLI, but has as such for visibility.

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Dec 13, 2021
@alan-agius4 alan-agius4 requested a review from dgp1130 December 13, 2021 09:36
@alan-agius4 alan-agius4 changed the title fix(@angular-devkit/build-angular): only extract CSS styles when are specified in styles option fix(@angular-devkit/build-angular): fail build when importing CSS files as an ECMA modules Dec 14, 2021
@alan-agius4 alan-agius4 requested a review from clydin December 15, 2021 09:23
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Dec 15, 2021
@alan-agius4 alan-agius4 removed the request for review from clydin January 26, 2022 19:36
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jan 26, 2022
…es as an ECMA modules

BREAKING CHANGE:

We now issue a build time error since importing a CSS file as an ECMA module is non standard Webpack specific feature, which is not supported by the Angular CLI.

This feature was never truly supported by the Angular CLI, but has as such for visibility.
@dgp1130 dgp1130 merged commit 07e776e into angular:master Jan 27, 2022
@alan-agius4 alan-agius4 deleted the css-extract branch January 27, 2022 19:10
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker flag: breaking change target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants