fix(@angular-devkit/build-angular): improve sourcemaps fidelity when code coverage is enabled #22016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: rc
alan-agius4
commented
Oct 26, 2021
| @@ -240,16 +238,10 @@ export default custom<AngularCustomOptions>(() => { | |||
| // `@ampproject/remapping` source map objects but both are compatible with Webpack. | |||
| // This method for merging is used because it provides more accurate output | |||
| // and is faster while using less memory. | |||
| result.map = { | |||
There was a problem hiding this comment.
No longer needed since there is a single babel pass!
clydin
reviewed
Oct 26, 2021
packages/angular_devkit/build_angular/src/webpack/utils/helpers.ts
Outdated
Show resolved
Hide resolved
clydin
approved these changes
Oct 26, 2021
|
@alan-agius4 this PR has conflicts, can you resolve them please? |
…code coverage is enabled With this change we replace `@jsdevtools/coverage-istanbul-loader` webpack loader with [`babel-plugin-istanbul`](https://github.com/istanbuljs/babel-plugin-istanbul) which is an official Babel plugin by the istanbuljs team. Previously, when code coverage was enabled we had multiple Babel runs on the same file. This is because istanbuljs' `instrumentSync` and `instrument` APIs which are used by the Webpack plugin invokes Babel directly https://github.com/istanbuljs/istanbuljs/blob/66bc39b3c7b301a4b4456101a9996f90b1638dc0/packages/istanbul-lib-instrument/src/instrumenter.js#L98 By using the babel plugin directly, we avoid this which also improves the sourcemaps correctness and test performance. Closes #22010
|
@filipesilva done. |
|
@alan-agius4 13.0.x still has merge conflicts, think you need separate PRs |
alan-agius4
added
target: minor
|
@filipesilva open a separate pr for rc branch |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we replace
@jsdevtools/coverage-istanbul-loaderwebpack loader withbabel-plugin-istanbulwhich is an official Babel plugin by the istanbuljs team.Previously, when code coverage was enabled we had multiple Babel runs on the same file. This is because istanbuljs'
instrumentSyncandinstrumentAPIs which are used by the Webpack plugin invokes Babel directly https://github.com/istanbuljs/istanbuljs/blob/66bc39b3c7b301a4b4456101a9996f90b1638dc0/packages/istanbul-lib-instrument/src/instrumenter.js#L98By using the babel plugin directly, we avoid this which also improves the sourcemaps correctness and test performance.
Closes #22010