chore(readme): update Bootstrap CSS inclusion example #2197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fair point. Marking to be merged. |
filipesilva
approved these changes
Sep 22, 2016
This commit fixes README example of including Bootstrap dependency in generated project in that way that Bootstrap CSS dependency is moved up - to be the first in build bundle. The reason behind this change is that Bootstrap comes with reset CSS code and globals that are intended to be global unless reset and changed by cascading file - here style.css. Thanks!
peterblazejewicz
force-pushed
the
chore/readme
branch
from
79db1c1 to
f000c77
Compare
JJayet
pushed a commit
to JJayet/angular-cli
that referenced
this pull request
Oct 2, 2016
This commit fixes README example of including Bootstrap dependency in generated project in that way that Bootstrap CSS dependency is moved up - to be the first in build bundle. The reason behind this change is that Bootstrap comes with reset CSS code and globals that are intended to be global unless reset and changed by cascading file - here style.css. Thanks! Close angular#2197
deebloo
pushed a commit
to deebloo/angular-cli
that referenced
this pull request
Oct 3, 2016
This commit fixes README example of including Bootstrap dependency in generated project in that way that Bootstrap CSS dependency is moved up - to be the first in build bundle. The reason behind this change is that Bootstrap comes with reset CSS code and globals that are intended to be global unless reset and changed by cascading file - here style.css. Thanks! Close angular#2197
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes README example of including Bootstrap dependency
in generated project in that way that Bootstrap CSS dependency is
moved up - to be the first in build bundle.
The reason behind this change is that Bootstrap comes with reset
CSS code and globals that are intended to be global unless reset
and changed by cascading file - here style.css.
Order of CSS styles inclusion:
Before:
after:
Thanks!