Skip to content

fix(service blueprint): Prevent unwanted ember service test generation #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2016

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Feb 18, 2016

The ember-cli generates blueprints for when generating a new
By overriding in it prevents the ember service test generation
Fixes #202

@filipesilva
Copy link
Contributor

Sweet. Also need this for the routes command myself.

@Brocco
Copy link
Contributor Author

Brocco commented Feb 18, 2016

I'm updating this PR to also handle generated route tests

…eneration

The ember-cli generates blueprints for  when generating a new service & route
By overriding  in  it prevents the ember service & route test generation
Fixes angular#202
@Brocco Brocco force-pushed the remove-ember-service-test branch from 366d1ae to 52b1b21 Compare February 18, 2016 12:19
@filipesilva
Copy link
Contributor

lgtm

@filipesilva filipesilva merged commit 52b1b21 into angular:master Feb 18, 2016
@Brocco Brocco deleted the remove-ember-service-test branch February 19, 2016 14:08
clydin pushed a commit that referenced this pull request Jun 5, 2018
hansl pushed a commit that referenced this pull request Jun 6, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng generate service also creates an ember test
2 participants