Skip to content

Unset config #20727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2021
Merged

Unset config #20727

merged 2 commits into from
May 10, 2021

Conversation

alan-agius4
Copy link
Collaborator

fix(@angular/cli): allow config object to be of JSON.

With this change we allow unset a config value to be a JSON.

Example, ng config -g schematics {} will remove the entire schematics section from the configuration.

fix(@angular/cli): allow unsetting config when value is undefined

With this change we allow unset a config value when the provided value is undefined.

Example, ng config -g schematics undefined will remove the entire schematics section from the configuration.

Closes #20718

With this change we allow unset a config value when the provided value is `undefined`.

Example, `ng config -g schematics undefined` will remove the entire `schematics` section from the configuration.
@alan-agius4 alan-agius4 added the target: rc This PR is targeted for the next release-candidate label May 10, 2021
@google-cla google-cla bot added the cla: yes label May 10, 2021
@alan-agius4 alan-agius4 requested a review from clydin May 10, 2021 13:11
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 10, 2021
With this change we allow unset a config value to be a JSON.

Example, `ng config -g schematics {}` will remove the entire `schematics` section from the configuration.
@filipesilva filipesilva merged commit 0a0fc41 into angular:master May 10, 2021
@alan-agius4 alan-agius4 deleted the unset-config branch May 10, 2021 21:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng new throw error Schematic input does not validate against the Schema
3 participants