Skip to content

[11.2.x] fix(@schematics/angular): pin karma-jasmine-html-reporter to patches in new projects #20720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021

Conversation

clydin
Copy link
Member

@clydin clydin commented May 7, 2021

Synchronizes the version pinning strategy with the other karma and jasmine project dependencies.
Allows project's created with npm 7+ to successfully install. [email protected] requires dependency versions not present in a new 11.2.x project.

Fixes #20719

…s in new projects

Synchronizes the version pinning strategy with the other karma and jasmine project dependencies.
Allows project's created with npm 7+ to successfully install. `[email protected]` requires dependency versions not present in a new 11.2.x project.

Fixes angular#20719
@clydin clydin added the target: patch This PR is targeted for the next patch release label May 7, 2021
@clydin clydin requested a review from alan-agius4 May 7, 2021 19:39
@google-cla google-cla bot added the cla: yes label May 7, 2021
@clydin clydin changed the title fix(@schematics/angular): pin karma-jasmine-html-reporter to patches in new projects [11.2.x] fix(@schematics/angular): pin karma-jasmine-html-reporter to patches in new projects May 7, 2021
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update jasmine-core instead?

@clydin
Copy link
Member Author

clydin commented May 8, 2021

I figured this would be the lower risk option for a patch release since it would maintain existing behavior prior to the new release of the reporter package.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 8, 2021
@filipesilva filipesilva merged commit dd3eb33 into angular:11.2.x May 10, 2021
@clydin clydin deleted the update-jasmine-11.2.x branch May 10, 2021 15:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants