refactor(all): Repackaging #2056
Conversation
hansl
force-pushed
the
repackaging
branch
4 times, most recently
from
892a5be to
0f1adc5
Compare
| "includes": [ | ||
| "./custom-typings.d.ts" | ||
| "blueprints/*/files/**/*", | ||
| "**/*.spec.ts" |
There was a problem hiding this comment.
What spec files are these?
There was a problem hiding this comment.
We'll move acceptance specs into this package later on. I can remove if you want.
There was a problem hiding this comment.
I'm going to remove and put back. This tsconfig was copied from the one in ast-tools.
| return files | ||
| .map((fileName) => path.relative(packagesRoot, fileName)) | ||
| .filter((fileName) => { | ||
| if (/^angular-cli.blueprints/.test(fileName)) { |
There was a problem hiding this comment.
Shouldn't this be /^angular-cli\/blueprints/ instead? There doesn't seem to be any file with angular-cli.blueprints in it's name.
There was a problem hiding this comment.
It's a regex, so . will match both / and \. Changed it to clearre.
There was a problem hiding this comment.
That didn't even occur to me, but of course it makes sense.
|
What is the goal/reason for this mega PR. |
|
Clarified the text. |
…ild-webpack is now a JS file)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Moving Angular-CLI into
packages/and building the angular-cli.The published packages will now have JavaScript only (with their d.ts), instead of being a mix of TypeScript and JavaScript, and it won't have the hacks of having a custom require extension to load the TypeScript.
Our development flow will be more streamlined, tools are going to be better (no more undefined symbols that are actually defined), and the npm packages will boot up way faster (since there's no more compilation during runtime).
Locally nothing changes, use
npm linkand run your localng. Using thenpmreleases though it should be all javascript from the release.The E2E tests also now uses the
distfolder output to install in the new E2E app, making sure the process works for an app published to npm.Note: Even though we're following the lerna structure, we won't be using their tool anytime soon.