fix(@angular-devkit/build-angular): update karma builder to use non-deprecated API #20485
Conversation
alan-agius4
added
the
target: major
| // Cleanup, signal Karma to exit. | ||
| return () => { | ||
| // Karma only has the `stop` method start with 3.1.1, so we must defensively check. | ||
| const karmaServerWithStop = (karmaServer as unknown) as { stop: () => Promise<void> }; |
There was a problem hiding this comment.
nit: I guess this is no longer relevant. Maybe fix in the follow-up PR?
| // Workaround for https://github.com/karma-runner/karma/issues/3154 | ||
| // When this workaround is removed, user projects need to be updated to use a Karma | ||
| // version that has a fix for this issue. | ||
| toJSON: () => { }, |
There was a problem hiding this comment.
nit: The issue has been fixed a while ago, so maybe cleanup in the follow-up PR?
| logger: context.logger, | ||
| }; | ||
|
|
||
| // @types/karma don't include the last parameter. |
There was a problem hiding this comment.
FYI I'm working on the fix for this and other issues in @types/karma. Should have a PR up soon.
There was a problem hiding this comment.
…eprecated API With this change we update the Karma builder to use the new Server API. Closes: #20479
|
Hey all, |
|
Is this change limited to the newest v12, or can it also be merged to the 11.2.x branch? |
|
@erikhorlings, this change is only merged in version 12. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
With this change we update the Karma builder to use the new Server API.
Closes: #20479