perf(@ngtools/webpack): avoid full compiler lazy route analysis on JIT rebuilds #20237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T rebuilds The deprecated lazy route string form requires code analysis prior to each build to locate any lazy routes and connect them with Webpack. This change uses the previous fast but less accurate AST based lazy route discovery for JIT rebuilds. The first build will still perform a full Angular compiler analysis to ensure an accurate list of all initial deprecated string form lazy routes.
clydin
force-pushed
the
webpack-plugin/lazy-route-perf
branch
from
8998c3d to
afced59
Compare
JoostK
reviewed
Mar 11, 2021
Comment on lines
+579
to
+580
| if (this.watchMode) { | ||
| this.ngtscNextProgram = angularProgram; |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecated lazy route string form requires code analysis prior to each build to locate any lazy routes and connect them with Webpack.
This change uses the previous fast but less accurate AST based lazy route discovery for JIT rebuilds. The first build will still perform a full Angular compiler analysis to ensure an accurate list of all initial deprecated string form lazy routes.