Skip to content

fix: Set awesome-typescript-loader version to 2.2.1 #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

JSMike
Copy link
Contributor

@JSMike JSMike commented Sep 6, 2016

The most recent update to awesome-typescript-loader is breaking new builds, hard coding the version to 2.2.1 resolves the issue for now

Fixes issue #1997

The most recent update to awesome-typescript-loader is breaking new builds, hard coding the version to 2.2.1 resolves the issue for now

Fixes issue angular#1997
@JSMike
Copy link
Contributor Author

JSMike commented Sep 6, 2016

The initial angular-cli@webpack version was using "awesome-typescript-loader": "^2.1.1" so this could potentially impact all angular-cli@webpack versions when creating a new project or when updating dependencies.

@TheLarkInn
Copy link
Member

Why does 2.2.3 cause errors? 😏 Find out why and then update the PR accordingly to make it work and I'll accept PR :)

@TheLarkInn
Copy link
Member

#1993 Already fixed as of right now. Thank you!

@TheLarkInn TheLarkInn closed this Sep 7, 2016
@JSMike
Copy link
Contributor Author

JSMike commented Sep 7, 2016

@TheLarkInn Thank you, was just in response to #1997. If #1993 fixes it then we're good to go.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants