correction sub-component path in windows when import to ngModule #1719 #1736 #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hansl LGTM |
| @@ -79,6 +79,7 @@ export function bootstrapItem( | |||
|
|
|||
| export function insertImport(fileToEdit: string, symbolName: string, | |||
| fileName: string, isDefault = false): Change { | |||
| fileName = fileName.replace(/\\/, '/'); // correction in windows | |||
There was a problem hiding this comment.
Actually, could you do a typescript if (process.platform.startsWith('win')) { fileName = fileName.replace(/\\/g, '/'); }
This will also fix the bug that it only replaces the first time this character appears.
|
Please rebase after and add a unit test please. |
|
@hansl can you have a look again? |
|
LGTM. Thanks! |
This was referenced Sep 22, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to ast-tool had been re-located. I closed PR #1736. and create a new PR.
this PR is to fix issue #1719.
Fix #1719