fix(tests): use current package in e2e tests #195
Conversation
| @@ -18,11 +18,10 @@ describe('Basic end-to-end Workflow', function () { | |||
| it('Installs angular-cli correctly', function() { | |||
| this.timeout(300000); | |||
|
|
|||
| sh.exec('npm link', { silent: true }); | |||
There was a problem hiding this comment.
Do you need to pass in the path to angular-cli?
There was a problem hiding this comment.
If I got this correctly, tests are always initiated from the root, which is why the setup with tmp dir works.
Although to be perfectly honest I couldn't find what the -C flag in npm install did in the command I removed.
There was a problem hiding this comment.
Yeah I'm pretty sure you need to pass in the path to angular-cli.
There was a problem hiding this comment.
npm link doesn't seem to take a path to link globally, only to link locally. Is there a missing argument in these docs that you know of?
|
Thanks! I was about to spend time on this, but if this works then 👍 Lets see what Travis says. |
|
There's something missing actually, also need to link inside the generated project. sec |
filipesilva
force-pushed
the
e2e-link-package
branch
from
c25985e to
cbf59c6
Compare
|
Closing this PR for now, as it it not fixing what is it intended to fix. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Close #194