Skip to content

fix(@angular-devkit/build-angular): add validation to fileReplacement values #19310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2020
Merged

fix(@angular-devkit/build-angular): add validation to fileReplacement values #19310

merged 1 commit into from
Nov 6, 2020

Conversation

alan-agius4
Copy link
Collaborator

fileReplacement is meant to replace compilation source files (JavaScript or TypeScript) with other compilation source files in the build. With this change we add validation to fail the build when the files have unsupported extensions.

Closes #11451

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Nov 5, 2020
@alan-agius4 alan-agius4 requested a review from clydin November 5, 2020 18:05
@google-cla google-cla bot added the cla: yes label Nov 5, 2020
@alan-agius4 alan-agius4 changed the title fix(@angular-devklit/build-angular): add validation to fileReplacement values fix(@angular-devkit/build-angular): add validation to fileReplacement values Nov 5, 2020
Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add mjs and cjs as well?

@alan-agius4
Copy link
Collaborator Author

Added.

… values

fileReplacement is meant to replace compilation source files (JavaScript or TypeScript) with other compilation source files in the build. With this change we add validation to fail the build when the files have unsupported extensions.

Closes #11451
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2020
@alan-agius4 alan-agius4 merged commit 424af28 into angular:master Nov 6, 2020
@alan-agius4 alan-agius4 deleted the file-replacement-validation branch November 6, 2020 20:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fileReplacements doesn't work with css files
2 participants