fix(@schematics/angular): remove solution style throw an error #18851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranshmil
force-pushed
the
fix-remove-solution-migration
branch
from
db9b1cc to
8ea0967
Compare
alan-agius4
reviewed
Sep 23, 2020
packages/schematics/angular/migrations/update-10/remove-solution-style-tsconfig.ts
Outdated
Show resolved
Hide resolved
alan-agius4
reviewed
Sep 23, 2020
packages/schematics/angular/migrations/update-10/remove-solution-style-tsconfig.ts
Outdated
Show resolved
Hide resolved
alan-agius4
reviewed
Sep 23, 2020
packages/schematics/angular/migrations/update-10/remove-solution-style-tsconfig_spec.ts
Outdated
Show resolved
Hide resolved
alan-agius4
requested changes
Sep 23, 2020
remove-solution-style-tsconfig migration fail when upgrading from version 10.0.* to 10.1.* with the following error: [error] Error: Could not read 'tsconfig.json'
eranshmil
force-pushed
the
fix-remove-solution-migration
branch
from
8ea0967 to
1f979e9
Compare
alan-agius4
added
action: merge
clydin
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove-solution-style-tsconfigmigration fails when upgrading from version 10.0.* to 10.1.* with the following error:There is no issue regarding this but you can see the following comments:
#18744 (comment)
#18040 (comment)
Btw, the files are not formatted correctly by the
prettierconfiguration but I decided to leave these changes out of the scope of this PR.