fix(@ngtools/webpack): add Webpack 5 to peer dependencies #18847
Conversation
valorkin
force-pushed
the
chore-ngtools-webpack-dep
branch
from
e99fc4d to
6d8d63d
Compare
| @@ -28,7 +28,7 @@ | |||
| "peerDependencies": { | |||
| "@angular/compiler-cli": "^11.0.0 || ^11.0.0-next", | |||
| "typescript": ">=3.9 < 4.1", | |||
| "webpack": "^4.0.0" | |||
| "webpack": "^4.0.0 || ^5.0.0" | |||
There was a problem hiding this comment.
Webpack version 5 is not yet stable thus the semver version here is invalid. It should be ^5.0.0-rc.0.
Chiming in @clydin just to confirm whether we should add this peerDependencies in the first place since Webpack 5 support is still experimental, and adding Webpack 5 might send out the wrong message.
There was a problem hiding this comment.
PS: chore is an invalid commit message type. You can use fix for this.
fix(@ngtools/webpack): add Webpack 5 to peer dependencies
There was a problem hiding this comment.
I know, just made it the same way as it appears in all other occurrences. I can change those to rc.0 too
There was a problem hiding this comment.
all comments applied
valorkin
force-pushed
the
chore-ngtools-webpack-dep
branch
from
6d8d63d to
665e999
Compare
valorkin
changed the title
valorkin
force-pushed
the
chore-ngtools-webpack-dep
branch
from
665e999 to
878ebc1
Compare
valorkin
changed the title
|
Thank you for the contribution. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Very minor addition to #18820
adding optional webpack@5 to peer dependencies of ngtools/webpack