Skip to content

Replace regex with correct project name valdiation #18831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

Jefiozie
Copy link
Contributor

If I understand the comments of @alan-agius4 on #17579 correct this PR will fix the IDE validation error that it is providing today.
I've replaced the regex with the correct one, just to make sure we are not forgetting when closing the ticket there is a second comment by @alan-agius4:

When it comes to project directories, I am inclined towards always dasherizing the project folder name to align with other schematics where the folder name is always dasherized, that being said It's not a biggy, as long as the schema validation is fixed.

Should we make a separate issue for this or are we leaving this as is?

Let me know if I need to make changes or add additional information.

Closes #17579

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Can you please update the commit message to match our guidelines in: https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#commit

Example

fix(@angular/cli): replace regex with correct project name validation

Closes #17579

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 21, 2020
@alan-agius4
Copy link
Collaborator

If I understand the comments of @alan-agius4 on #17579 correct this PR will fix the IDE validation error that it is providing today.
I've replaced the regex with the correct one, just to make sure we are not forgetting when closing the ticket there is a second comment by @alan-agius4:

When it comes to project directories, I am inclined towards always dasherizing the project folder name to align with other schematics where the folder name is always dasherized, that being said It's not a biggy, as long as the schema validation is fixed.

Should we make a separate issue for this or are we leaving this as is?

Let me know if I need to make changes or add additional information.

Closes #17579

I think for the time being we can leave this as is.

@Jefiozie
Copy link
Contributor Author

Hi @alan-agius4, yes I wil do this first thing tomorrow.

@Jefiozie Jefiozie force-pushed the fix_project_name_generation branch from ddc4352 to 61e16aa Compare September 22, 2020 05:24
@Jefiozie
Copy link
Contributor Author

Hi @alan-agius4, Í've made the changes as requested.

@Jefiozie Jefiozie force-pushed the fix_project_name_generation branch from 61e16aa to 1c4fcbe Compare September 22, 2020 09:16
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 22, 2020
@mgechev mgechev merged commit 432fcb0 into angular:master Sep 23, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2020
@Jefiozie Jefiozie deleted the fix_project_name_generation branch October 27, 2024 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated angular.json file does not correctly lower case the application name
4 participants