-
Notifications
You must be signed in to change notification settings - Fork 12k
Replace regex with correct project name valdiation #18831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
Can you please update the commit message to match our guidelines in: https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#commit
Example
fix(@angular/cli): replace regex with correct project name validation
Closes #17579
I think for the time being we can leave this as is. |
Hi @alan-agius4, yes I wil do this first thing tomorrow. |
ddc4352
to
61e16aa
Compare
Hi @alan-agius4, Í've made the changes as requested. |
61e16aa
to
1c4fcbe
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
If I understand the comments of @alan-agius4 on #17579 correct this PR will fix the IDE validation error that it is providing today.
I've replaced the regex with the correct one, just to make sure we are not forgetting when closing the ticket there is a second comment by @alan-agius4:
Should we make a separate issue for this or are we leaving this as is?
Let me know if I need to make changes or add additional information.
Closes #17579