fix(@schematics/angular): canLoad guard signature

[geromegrignon]

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

using the guard schematic with the --implements CanLoad option, the signature of the canLoad generated method is missing UrlTree.

export class TestGuard implements CanLoad {
  canLoad(
    route: Route,
    segments: UrlSegment[]): Observable<boolean> | Promise<boolean> | boolean {
    return true;
  }
}

Issue Number: #18751

What is the new behavior?

The schematic file has been updated to provide the following result :

export class TestGuard implements CanLoad {
  canLoad(
    route: Route,
    segments: UrlSegment[]): Observable<boolean | UrlTree> | Promise<boolean | UrlTree> | boolean | UrlTree {
    return true;
  }

Does this PR introduce a breaking change?

• Yes
• No

[geromegrignon]

Is there some action i can make to fix the CI error? I looked at the logs but couldn't figure out how the changes affected it.

[alan-agius4]

LGTM, thanks for this.

[alan-agius4]

Is there some action i can make to fix the CI error? I looked at the logs but couldn't figure out how the changes affected it.

Looks like a flake, I re-triggered the CI step

[alan-agius4]

@geromegrignon, just realised that you didn't add a Closes note in your commit message.

Can you update the commit please?

fix(@schematics/angular): update canLoad guard signature

Closes: #18751

Also for future contributions it's best to write the description of the PR as part of the commit message body.

Thanks

[geromegrignon]

I added the issue number and added a more complete body message.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}