Skip to content

fix(@angular-devkit/build-angular): suppress warning for CommonJS templateUrl and styleUrl #18259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2020
Merged

fix(@angular-devkit/build-angular): suppress warning for CommonJS templateUrl and styleUrl #18259

merged 1 commit into from
Jul 15, 2020

Conversation

alan-agius4
Copy link
Collaborator

Currently, when users use either absolute paths, or path mappings in JIT mode, we issue a warning for templateUrl and styleUrl. With this change we suppress those warning.

Closes: #18057

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jul 15, 2020
…plateUrl and styleUrl

Currently, when users use either absolute paths, or path mappings in JIT mode, we issue a warning for templateUrl and styleUrl. With this change we suppress those warning.

Closes: #18057
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jul 15, 2020
@alan-agius4 alan-agius4 requested a review from clydin July 15, 2020 10:45
@clydin clydin merged commit 2aedad9 into angular:master Jul 15, 2020
@alan-agius4 alan-agius4 deleted the jit-cjs-absolute-path branch July 15, 2020 17:53
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommonJS or AMD dependencies warnings with absolute path
5 participants