Skip to content

fix(@angular-devkit/build-angular): dedupe modules #18009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2020
Merged

fix(@angular-devkit/build-angular): dedupe modules #18009

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96f72a8
fix(@angular-devkit/build-angular): don't dedupe modules without a na…
alan-agius4 Jun 24, 2020
b50326e
fix(@angular-devkit/build-angular): don't dedupe linked modules
alan-agius4 Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions ...ngular_devkit/build_angular/src/angular-cli-files/plugins/dedupe-module-resolve-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,13 @@ interface NormalModuleFactoryRequest {
relativePath: string;
path: string;
descriptionFileData: {
name: string;
version: string;
name?: string;
version?: string;
};
descriptionFileRoot: string;
descriptionFilePath: string;
directory?: boolean;
file?: boolean;
}

export interface DedupeModuleResolvePluginOptions {
Expand All @@ -45,6 +47,17 @@ export class DedupeModuleResolvePlugin {
return;
}

// When either of these properties is undefined. It typically means it's a link.
// In which case we shouldn't try to dedupe it.
if (request.file === undefined || request.directory === undefined) {
return;
}

// Empty name or versions are no valid primary entrypoints of a library
if (!request.descriptionFileData.name || !request.descriptionFileData.version) {
return;
}

const moduleId = request.descriptionFileData.name + '@' + request.descriptionFileData.version;
const prevResolvedModule = this.modules.get(moduleId);

Expand Down