test: print stderr if DedupeModuleResolvePlugin not found #17973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit attempts to identify flakiness in the dedupe-duplicate-modules.ts test in which the signature string occasionally fails to show up in stderr. Dumping out the whole stderr would help us identify the bug. Example failure on master: https://app.circleci.com/pipelines/github/angular/angular-cli/7867/workflows/fdabb867-5dbe-4b85-80c5-24b6bca328dd/jobs/167264/steps
dgp1130
approved these changes
Jun 19, 2020
This was referenced Jun 22, 2020
clydin
pushed a commit
that referenced
this pull request
Jun 23, 2020
Following #17973, which we emitted the stderr when this test failed on CI. We see that the resolved module order sometimes changes, which is totally fine because of the async nature of the operation. https://circleci.com/gh/angular/angular-cli/167318#tests/containers/5 ``` [DedupeModuleResolvePlugin]: /tmp/angular-cli-e2e-i03vMQ/test-project/node_modules/tslib-1 -> /tmp/angular-cli-e2e-i03vMQ/test-project/node_modules/tslib-1-copy ``` With this change we handle both cases which should eliminate the flakes
kyliau
pushed a commit
that referenced
this pull request
Jun 24, 2020
Following #17973, which we emitted the stderr when this test failed on CI. We see that the resolved module order sometimes changes, which is totally fine because of the async nature of the operation. https://circleci.com/gh/angular/angular-cli/167318#tests/containers/5 ``` [DedupeModuleResolvePlugin]: /tmp/angular-cli-e2e-i03vMQ/test-project/node_modules/tslib-1 -> /tmp/angular-cli-e2e-i03vMQ/test-project/node_modules/tslib-1-copy ``` With this change we handle both cases which should eliminate the flakes (cherry picked from commit bf599e4)
villelahdenvuo
pushed a commit
to villelahdenvuo/angular-cli
that referenced
this pull request
Jul 6, 2020
Following angular#17973, which we emitted the stderr when this test failed on CI. We see that the resolved module order sometimes changes, which is totally fine because of the async nature of the operation. https://circleci.com/gh/angular/angular-cli/167318#tests/containers/5 ``` [DedupeModuleResolvePlugin]: /tmp/angular-cli-e2e-i03vMQ/test-project/node_modules/tslib-1 -> /tmp/angular-cli-e2e-i03vMQ/test-project/node_modules/tslib-1-copy ``` With this change we handle both cases which should eliminate the flakes
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attempts to identify flakiness in the dedupe-duplicate-modules.ts test
in which the signature string occasionally fails to show up in stderr.
Dumping out the whole stderr would help us identify the bug.
Example failure on master:
https://app.circleci.com/pipelines/github/angular/angular-cli/7867/workflows/fdabb867-5dbe-4b85-80c5-24b6bca328dd/jobs/167264/steps