fix(@angular/cli): throw error when specified project does not exist #17922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
requested changes
Jun 15, 2020
There was a problem hiding this comment.
Hi @kgajera,
Thanks for this, however I think a better approach would to throw an exception when a project doesn't exist in the first place which would also make the error message clearer.
You can add the below check right above the for..of.
let projectName = options.project;
if (projectName && !this._workspace.projects.has(projectName)) {
throw new Error(`Project '${projectName}' does not exist.`);
}
alan-agius4
added
the
action: cleanup
kgajera
force-pushed
the
improve-project-target-not-found-error
branch
from
11b33cf to
c9d52ee
Compare
Currently this falls through to a misleading error for an unsupported build target. Closes angular#17682
kgajera
force-pushed
the
improve-project-target-not-found-error
branch
from
c9d52ee to
a097fe0
Compare
|
@alan-agius4 Thanks, made the change. |
kgajera
changed the title
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check to see if the specified project exists, otherwise throws an error. This prevents it from falling through to the "build target not supported" error which is misleading.
Closes #17682