Skip to content

feat(@schematics/angular): enable lazy loading on the server for new projects #17352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2020
Merged

feat(@schematics/angular): enable lazy loading on the server for new projects #17352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cba11d
refactor(@angular-devkit/build-angular): remove deprecation of `named…
alan-agius4 Mar 31, 2020
5a3716e
feat(@schematics/angular): enable lazy loading on the server for new …
alan-agius4 Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/angular_devkit/build_angular/src/server/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,7 @@
"namedChunks": {
"type": "boolean",
"description": "Use file name for lazy loaded chunks.",
"default": true,
"x-deprecated": "Since version 9. This option has no effect on server platform."
"default": true
},
"bundleDependencies": {
"description": "Which external dependencies to bundle into the bundle. By default, all of node_modules will be bundled.",
Expand Down
1 change: 0 additions & 1 deletion packages/schematics/angular/universal/files/root/__tsconfigFileName__.json.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"extends": "./<%= tsConfigExtends %>",
"compilerOptions": {
"outDir": "<%= outDir %>-server",
"module": "commonjs",
"types": [
"node"
]
Expand Down
2 changes: 0 additions & 2 deletions packages/schematics/angular/universal/index_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ describe('Universal Schematic', () => {
extends: './tsconfig.app.json',
compilerOptions: {
outDir: './out-tsc/app-server',
module: 'commonjs',
types: ['node'],
},
files: [
Expand All @@ -116,7 +115,6 @@ describe('Universal Schematic', () => {
extends: './tsconfig.app.json',
compilerOptions: {
outDir: '../../out-tsc/app-server',
module: 'commonjs',
types: ['node'],
},
files: [
Expand Down
1 change: 0 additions & 1 deletion tests/angular_devkit/build_angular/hello-world-app-ve/src/tsconfig.server.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"extends": "./tsconfig.app.json",
"compilerOptions": {
"outDir": "../dist-server",
"module": "commonjs",
"types": []
},
"files": [
Expand Down
1 change: 0 additions & 1 deletion tests/angular_devkit/build_angular/hello-world-app/src/tsconfig.server.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"outDir": "../dist-server",
"baseUrl": "./",
"module": "commonjs",
"types": []
},
"files": [
Expand Down