-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@angular/cli): normalize yarnrc/npmrc options #17339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
merged label removed since PR hasn't got LGTM |
Superseded by #17358 |
@alan-agius4 Is there a particular reason why this was closed? Judging from this file conversion is hard-coded in NPM CLI and moving forward there is no better way than repeating it for relevant options in Angular CLI. |
@devoto13, the reason why this has been closed is because we rolled back Pacote to version 9, which is used in npm version 6 and this PR was no longer relevant. Pacote 10+ is a complete rewrite for npm 7.0 Unfortunately, the file mentioned is for npm, but in the case of the CLI we need to support other package managers. |
@alan-agius4 Thanks for the explanation. I saw the rollback to version 9, but thought it was more of a quick fix.
This was actually my point. Given that code in the linked file is not something Angular CLI can re-use and that other package managers should be supported, is there any reason to delay an upgrade to newer Pacote versions? I mean NPM@7 release will not make this process any easier. The logic to normalise property names needs to be re-implemented in Angular CLI as was started by this PR. My main reasoning for the update is that older |
Actually never mind. Just looked through the new dependency tree and it managed to grow 2 times in size despite removing obsolete dependencies. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #17314 and closes #16615