Skip to content

fix(@angular/cli): normalize yarnrc/npmrc options #17339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(@angular/cli): normalize yarnrc/npmrc options #17339

wants to merge 2 commits into from

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Mar 30, 2020

Closes #17314 and closes #16615

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Mar 30, 2020
@alan-agius4 alan-agius4 requested a review from clydin March 30, 2020 09:40
@alan-agius4 alan-agius4 changed the title fix(@angular/cli): camelize yarnrc/npmrc options fix(@angular/cli): normalize yarnrc/npmrc options Mar 30, 2020
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 30, 2020
@kyliau kyliau removed the action: merge The PR is ready for merge by the caretaker label Mar 30, 2020
@kyliau
Copy link
Contributor

kyliau commented Mar 30, 2020

merged label removed since PR hasn't got LGTM

@alan-agius4
Copy link
Collaborator Author

Superseded by #17358

@alan-agius4 alan-agius4 closed this Apr 1, 2020
@devoto13
Copy link
Contributor

@alan-agius4 Is there a particular reason why this was closed?

Judging from this file conversion is hard-coded in NPM CLI and moving forward there is no better way than repeating it for relevant options in Angular CLI.

@alan-agius4 alan-agius4 deleted the camelize-rc-options branch April 28, 2020 13:11
@alan-agius4
Copy link
Collaborator Author

@devoto13, the reason why this has been closed is because we rolled back Pacote to version 9, which is used in npm version 6 and this PR was no longer relevant. Pacote 10+ is a complete rewrite for npm 7.0

Unfortunately, the file mentioned is for npm, but in the case of the CLI we need to support other package managers.

@devoto13
Copy link
Contributor

@alan-agius4 Thanks for the explanation. I saw the rollback to version 9, but thought it was more of a quick fix.

Unfortunately, the file mentioned is for npm, but in the case of the CLI we need to support other package managers.

This was actually my point. Given that code in the linked file is not something Angular CLI can re-use and that other package managers should be supported, is there any reason to delay an upgrade to newer Pacote versions? I mean NPM@7 release will not make this process any easier. The logic to normalise property names needs to be re-implemented in Angular CLI as was started by this PR.

My main reasoning for the update is that older pacote pulls plenty of older dependencies/polyfills and updating will allow to shrink some MBs from the CLI installation size.

@devoto13
Copy link
Contributor

Actually never mind. Just looked through the new dependency tree and it managed to grow 2 times in size despite removing obsolete dependencies.

@clydin clydin removed their request for review April 28, 2020 15:00
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng update failes to latest version 9.1.0: unable to get local issuer certificate noproxy config is not respected when running ng update
4 participants