Skip to content

fix(@angular-devkit/build-webpack): rewrite ES5 polyfills file name #16169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dgp1130
Copy link
Collaborator

@dgp1130 dgp1130 commented Nov 12, 2019

The asset name is incorrect because the file is renamed after generation by Webpack, so the stats file contains a broken link. This hacks together a quick rewrite to the asset list to use the new filename.

…ngular#15915)

The name is incorrect because the file is renamed after generation by Webpack, so the stats file contains a broken link. This hacks together a quick rewrite to the asset list to use the new filename.
@dgp1130 dgp1130 added the target: patch This PR is targeted for the next patch release label Nov 12, 2019
@dgp1130 dgp1130 added this to the v9-blockers milestone Nov 12, 2019
@dgp1130 dgp1130 requested a review from clydin November 12, 2019 23:38
@dgp1130 dgp1130 self-assigned this Nov 12, 2019
@dgp1130
Copy link
Collaborator Author

dgp1130 commented Nov 13, 2019

Charles found a way to do this with a Webpack plugin in a much less hacky way. Closing this PR in favor of that one.

#16181

@dgp1130 dgp1130 closed this Nov 13, 2019
@dgp1130 dgp1130 deleted the bundle-analyzer branch November 13, 2019 17:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants