Skip to content

[LTS] - refactor(@angular/cli): fix incorrect merge in install package #16072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2019
Merged

[LTS] - refactor(@angular/cli): fix incorrect merge in install package #16072

merged 1 commit into from
Nov 6, 2019

Conversation

alan-agius4
Copy link
Collaborator

This is to align with current master

// setup prefix/global modules path
const packageManagerArgs = getPackageManagerArguments(packageManager);
const tempNodeModules = join(tempPath, 'node_modules');
const installArgs: string[] = [
packageManagerArgs.prefix,
// Yarn will no append 'node_modules' to the path
packageManager === PackageManager.Yarn ? tempNodeModules : tempPath,
packageManagerArgs.noLockfile,
];
installPackage(packageName, logger, packageManager, true, installArgs, tempPath);

Related to #16064

@alan-agius4 alan-agius4 changed the title refactor(@angular/cli): fix incorrect merge in install package [LTS] - refactor(@angular/cli): fix incorrect merge in install package Nov 5, 2019
@alan-agius4 alan-agius4 requested a review from clydin November 5, 2019 19:53
@vikerman vikerman merged commit 9e7000d into angular:8.3.x Nov 6, 2019
@alan-agius4 alan-agius4 deleted the patch-lts-incorrect-merge branch November 6, 2019 05:15
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants