Skip to content

refactor(NgModule): update to RC5 #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2016
Merged

refactor(NgModule): update to RC5 #1579

merged 1 commit into from
Aug 9, 2016

Conversation

jkuri
Copy link
Contributor

@jkuri jkuri commented Aug 6, 2016

No description provided.

@jkuri jkuri force-pushed the ng-module branch 2 times, most recently from 9b48d28 to 9fb1567 Compare August 6, 2016 17:15
let changeImport: InsertChange = new InsertChange(modulePath, iStart, iStr);

return changeImport.apply().then(() => {
source = this.getSource(modulePath);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this. Just call getSource().

@hansl hansl merged commit e89d6f4 into angular:master Aug 9, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants