Skip to content

fix(commands): ember-cli branding leaks through many error messages a… #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jkuri
Copy link
Contributor

@jkuri jkuri commented Jan 28, 2016

Prevent ember-cli version message on every executed command. Also applies on warning when overriding core ember-cli commands and replaces all ember output strings with ng.
That was a known issue and I removed it from README.md.

@jkuri
Copy link
Contributor Author

jkuri commented Jan 29, 2016

Closes #12

@Brocco
Copy link
Contributor

Brocco commented Jan 29, 2016

@IgorMinar please take a look at this, I know you had some thought about how to handle this issue.

@cironunes
Copy link
Member

it's fair enough for now. lgtm

@jkuri
Copy link
Contributor Author

jkuri commented Jan 31, 2016

I believe this is the only way to get rid of the ember-cli leaks. I made some investigation on this and noticed; lookup-command.js and cli.js are coded in the way that cannot be overriden. So, this "hacky" thing to intercept node stdout and stderr before printing is in my opinion the only solution to this problem.
Btw, I also noticed serve.js, which should solve the Windows users issue due to lack of performance not running as administrator. Since we upgraded ember-cli to version 1.13.15 this should also be resolved, but this need to be tested before removing from README.md as known issue.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants