fix(@ngtools/webpack): only add ctor params to decorated classes #15416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
LGTM
2 NIT’s, commit should close #15404 and maybe add a test for an undecorated class?
|
Was waiting on confirmation that the referenced issue was indeed caused by this. I'll add it now. |
clydin
force-pushed
the
fix-ctor-params-decorators
branch
from
1bd8663 to
a02f91b
Compare
mgechev
pushed a commit
that referenced
this pull request
Aug 23, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mimics the behavior of TypeScript's
emitDecoratorMetadataoption.