Skip to content

feat(@angular/cli): update with migrate only creates commit per migration #15414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 22, 2019

Support for a full update will be implemented in a follow up PR.

@clydin clydin added the target: major This PR is targeted for the next major release label Aug 22, 2019
@clydin clydin requested a review from alan-agius4 August 23, 2019 18:37
@clydin clydin force-pushed the migration-refactor branch from ca70a18 to 9d2b6d2 Compare August 25, 2019 00:32
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I love the refactor.

Couple of small NITS

@clydin clydin force-pushed the migration-refactor branch from 9d2b6d2 to 42401d8 Compare August 26, 2019 13:50
@clydin clydin force-pushed the migration-refactor branch from 42401d8 to 9c9f7ad Compare August 26, 2019 15:59
@mgechev mgechev merged commit 891fe52 into angular:master Aug 26, 2019
@clydin clydin deleted the migration-refactor branch August 26, 2019 18:52
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants