fix(@schematics/angular): default interface for guard #15313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
reviewed
Aug 12, 2019
alan-agius4
reviewed
Aug 12, 2019
alan-agius4
requested changes
Aug 12, 2019
alan-agius4
reviewed
Aug 12, 2019
|
What about adding |
|
I think the combination of all the suggested above. Will fix this schematic for both interactive and not. As at the moment when not interactive the valid implementation is too loose. |
cexbrayat
force-pushed
the
feat/default-guard-interface
branch
from
cd20e84 to
9b3d508
Compare
cexbrayat
changed the title
|
@alan-agius4 I amended the commit with your suggestions and @clydin 's 👍 That should handle the interactive and non interactive cases. |
alan-agius4
reviewed
Aug 16, 2019
alan-agius4
reviewed
Aug 16, 2019
alan-agius4
reviewed
Aug 16, 2019
cexbrayat
force-pushed
the
feat/default-guard-interface
branch
from
9b3d508 to
c3d15b6
Compare
Currently, if the user hits `<Enter>` before selecting an interface to implement, the CLI generates a broken guard that implements no interface. With this commit, the CLI forces a choice in interactive mode and generates a `CanActivate` guard by default.
alan-agius4
approved these changes
Aug 16, 2019
alan-agius4
added
the
target: patch
cexbrayat
force-pushed
the
feat/default-guard-interface
branch
from
c3d15b6 to
f48286e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the user hits
<Enter>before selecting an interface to implement, the CLI will generate a broken guard that implements no interface. With this commit, the CLI generates aCanActivateguard by default.