Skip to content

fix(@schematics/angular): add manifest.webmanifest to the list of p… #15277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2019
Merged

fix(@schematics/angular): add manifest.webmanifest to the list of p… #15277

merged 1 commit into from
Aug 12, 2019

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Aug 8, 2019

In the latest versions of Chrome Version 76.0.3809.100, the manifest.webmanifest is being requested when offline and is causing a 504 error.

#15259 (comment)

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Aug 8, 2019
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a schematics point of view, I expect @gkalpak to know more about the ngsw functionality side of things.

…refetched files in ngws-config.json

In the latest versions of Chrome Version 76.0.3809.100, the `manifest.webmanifest` is being requested when offline and is caused a 504 error.

#15259 (comment)
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mgechev mgechev merged commit d1b0448 into angular:master Aug 12, 2019
mgechev pushed a commit that referenced this pull request Aug 12, 2019
…refetched files in ngws-config.json (#15277)

In the latest versions of Chrome Version 76.0.3809.100, the `manifest.webmanifest` is being requested when offline and is caused a 504 error.

#15259 (comment)
@alan-agius4 alan-agius4 deleted the schematics-webmanifest-fix branch August 26, 2019 11:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants