Skip to content

fix(@angular-devkit/build-angular): add back raw-loader for html #15248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(@angular-devkit/build-angular): add back raw-loader for html #15248

wants to merge 1 commit into from

Conversation

mparthoens
Copy link

This commit 98c2747 caused a regression when not using directTemplateLoading which in some cases needs to be supported for AngularJS apps.

Fixes #14855

This commit 98c2747 caused a regression when not using directTemplateLoading which in some cases needs to be supported for AngularJS apps.

Fixes #14855
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mparthoens
Copy link
Author

import html still not working.
getting the message:
ERROR in ./src/app/views/contact/contact.component.ts
Module not found: Error: Can't resolve '../../../assets/HTMLTemplates/ontactMessage.html' in 'C:\Sources\ngCSW\Production\IdChips\IdChips-SPA\src\app\views\contact'

@mparthoens mparthoens closed this Aug 5, 2019
@mparthoens mparthoens reopened this Aug 5, 2019
@mparthoens
Copy link
Author

Import Html still not working.
Get the message when trying to assign loaded html file content to a variable.
ERROR in ./src/assets/HTMLTemplates/contactMessage.html 1:0
Module parse failed: Unexpected token (1:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders

|


|
i 「wdm」: Failed to compile.

@alan-agius4
Copy link
Collaborator

Hi, thanks for this, but as per my comment (#14855 (comment)) in the issue linked above. We have discussed this during one of our meeting and we feel that it's best not support webpack specific features.

Thanks for your understanding and apologies for any inconvenience this might cause.

@alan-agius4 alan-agius4 closed this Aug 5, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

require html stopped working in upgrade to angular 8
3 participants