fix(@angular-devkit/build-angular): never use component css sourcemap…

[filipesilva]

… when optimizations are on.

It will just increase bundle size without offering good debug experience.

[filipesilva]

According to @IgorMinar:

If you are building the app with build build optimizations on, we should not inline any sourcemaps at all.

The inline sourcemaps are useful for dev mode and debugging runtime issue, but don't help prod debugging easier in a way that you couldn't use devmode for and only add a lot of weight.

[alan-agius4]

You should actually check it style optimization is enabled. As styles optimization can be disabled.

Ie !buildOptions.optimization.styles

[filipesilva]

You're right, and that's also what was breaking a server builder test. Thanks!

[alan-agius4]

At the moment you are also disabling sourcemaps when opimizations are turned off.

Optimization is not a boolean but a complex object, users can choose what they want to optimize.

[alan-agius4]

LGTM

[clydin]

Should there be some type of information message/warning for this case? It is changing the users settings silently.

Or maybe just a warning that this is not a recommended configuration? Maybe the developer really wants the source maps?

[clydin]

Actually, any reason we can't create file source maps for the component stylesheets?

[filipesilva]

I'm not sure if the if the AOT compiler supports non-inline css sourcemaps actually. @IgorMinar @alxhub should we use them?

[clydin]

Would it matter at the AOT level? It's just a different source map comment url.

[filipesilva]

I vaguely remember it mattered for AOT debugging, but not sure anymore. I think that's why we always inline them.

[alan-agius4]

I think the problem was that when not inlining it didn’t work for a number of use cases.

• Components styles sourcemaps didn’t work on SSR unless inlined.
• I don’t think that client bundles can have multiple sourcemaps urls.

[clydin]

The bundles wouldn't. The injected style elements would each have one. Instead of a data URL they would have a file URL.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}