Skip to content

fix(@angular-devkit/build-angular): various breakpoints issues #15221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2019
Merged

fix(@angular-devkit/build-angular): various breakpoints issues #15221

merged 1 commit into from
Aug 2, 2019

Conversation

alan-agius4
Copy link
Collaborator

With this change we address 2 main issues related to unbound breakpoints:

  1. in VS code when having a baseHref set.
  2. Visual Studio when using an SPA inside a ASP.NET project

For the latter, it seems that there is no way to set a webRoot. However, webpack:/// seems to be handled internally and will be mapped to the SpaRoot ie ClientApp folder.

Fixes: #15211

With this change we address 2 main issues related to unbound breakpoints:
1) in VS code when having a `baseHref` set.
2) Visual Studio when using an SPA inside a ASP.NET project

For the latter, it seems that there is no way to set a `webRoot`. However, `webpack:///` seems to be handled internally and will be mapped to the `SpaRoot` ie `ClientApp` folder.

Fixes: #15211
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Aug 1, 2019
@alan-agius4 alan-agius4 requested a review from clydin August 1, 2019 08:55
@kyliau kyliau merged commit 195e493 into angular:master Aug 2, 2019
@alan-agius4 alan-agius4 deleted the sourcemap-ide branch August 3, 2019 06:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
4 participants