fix(@angular-devkit/build-optimizer): don't wrap enum like nodes whic… #15165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
clydin
reviewed
Jul 25, 2019
packages/angular_devkit/build_optimizer/src/transforms/wrap-enums.ts
Outdated
Show resolved
Hide resolved
…h are inside of methods. With this change we stop recursive lookup when the current node is not a BlockLike. This change should also, improve the BO overall speed as it's reduces a lot of recursive lookups. Fixes #15145
alan-agius4
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…h are inside of methods.
With this change we stop recursive lookup when the current node is not a BlockLike.
This change should also improve the BO overall speed as it's reduces a lot of recursive lookups.
Fixes #15145
Note: Tested also on AIO to confirm size regression and didn't see any increase in file size in both ES5 and ES2015 builds