fix(@ngtools/webpack): HTML and style changes in libraries is not ref… #15146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
…lected in applications during VE AOT During AOT compilations, apart from the `d.ts` and `.js` changes we need to handle summary changes and metadata depedencies for libraries. NGC compiler doesn't allow us to purge known changed summaries, this change implements a workaround for this, which allows us to have incrementality for component resources in libraries. Fixes #13588
alan-agius4
requested review from
filipesilva
and removed request for
filipesilva
filipesilva
suggested changes
Jul 25, 2019
| it('rebuilds AOT works with library HTML and CSS changes', async () => { | ||
| // DISABLED_FOR_IVY - Not yet supported under Ivy | ||
| if (ivyEnabled) { | ||
| pending('Not supported in Ivy'); |
There was a problem hiding this comment.
Is this not supported or just not relevant? I imagine it should just work. If it does, we should test it.
There was a problem hiding this comment.
It’s not supported because ngcc is non incremental. This should eventually work when we have dev libs in ivy mode.
| // Note: NGTSC program doesn't implement 'getLibrarySummaries' method. | ||
| const originalGetLibrarySummaries = oldProgram.getLibrarySummaries; | ||
|
|
||
| oldProgram.getLibrarySummaries = () => { |
Closed
15 tasks
|
See: #17736 (comment) |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lected in applications during VE AOT
During AOT compilations, apart from the
d.tsand.jschanges we need to handle summary changes and metadata depedencies for libraries.NGC compiler doesn't allow us to purge known changed summaries, this change implements a workaround for this, which allows us to have incrementality for component resources in libraries.
Fixes #13588