Skip to content

fix(@angular-devkit/build-angular): use query option to set sockJS path in dev-server #15003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Jul 5, 2019

Newer versions of webpack-dev-server do not honor the path segment of the passed URL and requires the query option to be used to configure the sockjs path of the reload client code. This only affects 8.1+ as the version of webpack-dev-server used in 8.0.x does not have this requirement.

Fixes #15002

@clydin clydin added the target: major This PR is targeted for the next major release label Jul 5, 2019
@clydin clydin added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Jul 7, 2019
@clydin clydin requested a review from filipesilva July 8, 2019 16:36
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a disabled test for live reload, would it have caught this regression? Should it be re-enabled?

@kyliau kyliau merged commit 445f387 into angular:master Jul 9, 2019
@clydin clydin deleted the fix-webpack-sockjs-path branch July 9, 2019 20:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sockjs-node url is ignoring the 'pathname' part of the publicHost
4 participants