Skip to content

fix(@angular/cli): add verbose option to update and add #15000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2019
Merged

fix(@angular/cli): add verbose option to update and add #15000

merged 1 commit into from
Jul 9, 2019

Conversation

alan-agius4
Copy link
Collaborator

At the moment there is no way to turn on the verbose logging for ng update and ng add. This is useful for use so that when users report issues such as npmrc is not read we can see the lookup locations.

This also removes some reduncant that were being provided in executeSchematic.

Related to #14993

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed cla: yes labels Jul 5, 2019
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@alan-agius4 alan-agius4 requested a review from clydin July 5, 2019 08:10
@@ -30,6 +30,11 @@
"format": "hostname"
}
]
},
"verbose": {
"description": "When true, display additional details during the add process.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When true, doesn't really make sense here since it's a flag.
Can you also make the description more generic? I'd like to eventually make it a global option for all commands.
Something maybe like: Display additional details about internal operations during execution.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree with you, through probably regarding the “When true”, we should probably remove it from all of the other descriptions as well. As it seems to be some the standard for Boolean options.

@alan-agius4 alan-agius4 requested a review from clydin July 8, 2019 06:14
At the moment there is no way to turn on the verbose logging for `ng update` and `ng add`. This is useful for use so that when users report issues such as npmrc is not read we can see the lookup locations.

This also removes some reduncant that were being provided in `executeSchematic`.

Related to #14993
@kyliau kyliau merged commit 3d1d225 into angular:master Jul 9, 2019
@alan-agius4 alan-agius4 deleted the add-verbose-to-ng-add-ng-update branch July 9, 2019 20:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants