Skip to content

fix(@schematics/update): update @angular/pwa when migrating to 8 #14996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2019
Merged

fix(@schematics/update): update @angular/pwa when migrating to 8 #14996

merged 1 commit into from
Jul 9, 2019

Conversation

alan-agius4
Copy link
Collaborator

Related to #14589 (comment)

@alan-agius4 alan-agius4 requested a review from clydin July 4, 2019 11:38
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jul 4, 2019
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good that the @angular/pwa package will now stay in sync, if it's installed. However, the package doesn't seem to provide any useful functionality other than it's ng add schematic.

  • Are there plans to actually add ng g schematics for @angular/pwa?
  • It seems like ng update @angular/service-worker would handle breaking changes there if any should occur?
  • Is the idea that @angular/pwa would provide an update schematic if the Web App Manifest standards had some breaking changes or important new features?

I'm just trying to figure out the value of this package staying installed after ng add is run.

@clydin
Copy link
Member

clydin commented Jul 8, 2019

There is currently no method to execute ng add schematics without installing the containing package first. This is actually something I have considered supporting as there is the potential for a package that will only serve as a vehicle for the addition schematics and having it otherwise installed just adds noise to the project.

@kyliau kyliau merged commit d8bdf86 into angular:master Jul 9, 2019
@alan-agius4 alan-agius4 deleted the fix-pwa-update branch July 9, 2019 20:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants