Skip to content

fix(@angular-devkit/build-optimizer): wrap classes with a let variable #14989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Jul 3, 2019

Classes can technically be re-assigned. By using a let variable this behavior will be retained and prevent potential runtime errors.

Fixes #14930

Classes can technically be re-assigned.  By using a let variable this behavior will be retained and prevent potential runtime errors.

Fixes angular#14930
@clydin clydin added the target: patch This PR is targeted for the next patch release label Jul 3, 2019
@clydin clydin requested a review from alan-agius4 July 3, 2019 23:38
@kyliau kyliau merged commit 8752f21 into angular:master Jul 9, 2019
@clydin clydin deleted the let-class-wrap branch July 9, 2019 20:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng serve --prod with buildOptimizer turn on reports "Uncaught TypeError: Assignment to constant variable."
4 participants